Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix and re-enable basic login selector functional tests. #106822

Merged
merged 1 commit into from
Jul 28, 2021
Merged

Fix and re-enable basic login selector functional tests. #106822

merged 1 commit into from
Jul 28, 2021

Conversation

azasypkin
Copy link
Member

@azasypkin azasypkin commented Jul 27, 2021 •
edited
Loading

Summary

Flaky test run (100 executions, 0 failures): https://kibana-ci.elastic.co/job/kibana+flaky-test-suite-runner/1780/

Fixes: #98562

@azasypkin azasypkin added Team:Security Team focused on: Auth, Users, Roles, Spaces, Audit Logging, and more! Feature:Security/Authentication Platform Security - Authentication release_note:skip Skip the PR/issue when compiling release notes test-failure-flaky 7.15 candidate labels Jul 27, 2021
azasypkin
azasypkin commented Jul 27, 2021
View reviewed changes
x-pack/test/security_functional/tests/login_selector/basic_functionality.ts
@@ -121,24 +120,25 @@ export default function ({ getService, getPageObjects }: FtrProviderContext) {
.post('/authentication/app/setup')
.send({ simulateUnauthorized: false })
.expect(200);
await PageObjects.security.loginSelector.login('basic', 'basic1');
await PageObjects.security.loginSelector.login('basic', 'basic1', {
Copy link
Member Author

@azasypkin azasypkin Jul 27, 2021 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

note: the issue is explained here #98562 (comment). The idea is to use chromeless app that doesn't make any unnecessary requests that may trigger logout earlier than we need.

@azasypkin azasypkin added the auto-backport Deprecated - use backport:version if exact versions are needed label Jul 27, 2021
@kibanamachine
Copy link
Contributor

💚 Build Succeeded

Metrics [docs]

✅ unchanged

History

  • 💚 Build #140946 succeeded 857451309dd09fca3e51e9236c1947c7b2ae182d

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@azasypkin azasypkin marked this pull request as ready for review July 27, 2021 17:11
@azasypkin azasypkin requested a review from a team as a code owner July 27, 2021 17:11
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-security (Team:Security)

legrego
legrego approved these changes Jul 27, 2021
View reviewed changes
Copy link
Member

@legrego legrego left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@azasypkin azasypkin merged commit 0bb761d into elastic:master Jul 28, 2021
@azasypkin azasypkin deleted the issue-xxx-tests branch July 28, 2021 07:25
@kibanamachine
Copy link
Contributor

💔 Backport failed

Status Branch Result
❌ 7.x Commit could not be cherrypicked due to conflicts

To backport manually run:
node scripts/backport --pr 106822

@azasypkin azasypkin mentioned this pull request Jul 28, 2021
Merged
azasypkin added a commit that referenced this pull request Jul 28, 2021
@azasypkin
Fix and re-enable basic login selector functional tests. (#106822) (#…
4135240 
…106956)

# Conflicts:
#	x-pack/test/security_functional/tests/login_selector/basic_functionality.ts
streamich pushed a commit to vadimkibana/kibana that referenced this pull request Aug 8, 2021
@azasypkin @vadimkibana
Fix and re-enable basic login selector functional tests. (elastic#106822
5f769b9 
)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@legrego legrego legrego approved these changes

Assignees
No one assigned
Labels
auto-backport Deprecated - use backport:version if exact versions are needed Feature:Security/Authentication Platform Security - Authentication release_note:skip Skip the PR/issue when compiling release notes Team:Security Team focused on: Auth, Users, Roles, Spaces, Audit Logging, and more! test-failure-flaky v7.15.0
Projects
None yet
Milestone
No milestone
4 participants
@azasypkin @kibanamachine @elasticmachine @legrego